Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XXHash for stripe size #61881

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Fix XXHash for stripe size #61881

merged 1 commit into from
Nov 22, 2021

Conversation

Tornhoof
Copy link
Contributor

Closes #61878

Fixes the (multiple of) stripe size case and adds explicit tests for this specific case.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2021
@ghost
Copy link

ghost commented Nov 20, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #61878

Fixes the (multiple of) stripe size case and adds explicit tests for this specific case.

Author: Tornhoof
Assignees: -
Labels:

area-System.IO

Milestone: -

@Tornhoof
Copy link
Contributor Author

The build failure does not appear to be related, an arm debug build was terminated after a timeout.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Tornhoof !

@bartonjs should we backport it to 6.0?

@adamsitnik adamsitnik merged commit f1edeed into dotnet:main Nov 22, 2021
@filipnavara
Copy link
Member

Given the incorrectly generated results and pretty small area of the fix I'd say it's worth porting to release branch (especially a LTS one).

@Tornhoof Tornhoof deleted the XxHashFixes branch November 22, 2021 11:53
@Tornhoof
Copy link
Contributor Author

I'd recommend backporting too.

@bartonjs
Copy link
Member

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1491225615

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XXHash64/32 incorrect one-shot implementation
4 participants