Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not explicitly pass type to VNForMapStore #61882

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Do not explicitly pass type to VNForMapStore #61882

merged 2 commits into from
Nov 22, 2021

Commits on Nov 20, 2021

  1. Fix type checks in fgValueNumberArrIndexAssign 

    The code was trying to obtain the value of the location to store
to from the updated map for the element. This is simply incorrect
for all but the trivial case of an empty field sequence.
    @SingleAccretion
    SingleAccretion committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    9b2cb87 View commit details
    Browse the repository at this point in the history

  2. Do not explicitly pass type to VNForMapStore 

    It must always be equal to the type of the map being updated,
not having redundancy eliminates the possibility for mistakes.
    @SingleAccretion
    SingleAccretion committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    a5bfcd2 View commit details
    Browse the repository at this point in the history