-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix optComputeLoopSideEffects
to account for HWI stores
#61911
Merged
jakobbotsch
merged 3 commits into
dotnet:main
from
SingleAccretion:Fix-optComputeLoopSideEffects-For-Simd
Nov 29, 2021
Merged
Fix optComputeLoopSideEffects
to account for HWI stores
#61911
jakobbotsch
merged 3 commits into
dotnet:main
from
SingleAccretion:Fix-optComputeLoopSideEffects-For-Simd
Nov 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we can end up not seeing the loop has memory havoc. Also added an assert that will prevent this issue from arising in the future.
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Nov 22, 2021
dotnet-issue-labeler
bot
added
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
and removed
community-contribution
Indicates that the PR has been added by a community member
labels
Nov 22, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsOtherwise we can end up not seeing the loop has memory havoc. Also added an assert that will prevent this issue from arising in the future. A few small diffs in methods where we had such loops. Win-x64 diffsbenchmarks.run.windows.x64.checked.mch:
Detail diffs
libraries.pmi.windows.x64.checked.mch:
Detail diffs
Full diffs pending SPMI in CI.
|
@dotnet/jit-contrib, @tannergooding |
tannergooding
approved these changes
Nov 22, 2021
jakobbotsch
reviewed
Nov 29, 2021
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
jakobbotsch
approved these changes
Nov 29, 2021
Thanks for the fix! |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Dec 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we can end up not seeing the loop has memory havoc.
Also added an assert that will prevent this issue from arising in the future.
A few small diffs in methods where we had such loops.
Win-x64 diffs
benchmarks.run.windows.x64.checked.mch:
Detail diffs
libraries.pmi.windows.x64.checked.mch:
Detail diffs
Full diffs.