Use correct VN relation kind for redundant relop opts #61912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could overwrite the candidate VN relation kind with one from an earlier tree that did not necessarily end up as a candidate. Fix dotnet#61908
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe could overwrite the candidate VN relation kind with one from an Fix #61908 cc @AndyAyersMS
|
|
I got far enough that I figured I would just submit the fix. Logic seems sound enough, just a small oversight in how the VN relation kind for the candidate was propagated. |
AndyAyersMS
approved these changes
Nov 22, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could overwrite the candidate VN relation kind with one from an
earlier tree that did not necessarily end up as a candidate.
Fix #61908
cc @AndyAyersMS