Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable several GenericMath tests on iOS/tvOS #61922

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Disable several GenericMath tests on iOS/tvOS #61922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a37e80f
Disable several GenericMath tests on iOS/tvOS
Nov 22, 2021
700306c
Wrong GenericMath tests
Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libraries/System.Runtime/tests/System/IntPtrTests.GenericMath.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ public static void CreateSaturatingFromCharTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateSaturatingFromInt16Test()
{
Assert.Equal((nint)0x00000000, NumberHelper<nint>.CreateSaturating<short>(0x0000));
Expand Down Expand Up @@ -846,6 +847,7 @@ public static void CreateSaturatingFromIntPtrTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateSaturatingFromSByteTest()
{
Assert.Equal((nint)0x00000000, NumberHelper<nint>.CreateSaturating<sbyte>(0x00));
Expand Down Expand Up @@ -949,6 +951,7 @@ public static void CreateTruncatingFromCharTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateTruncatingFromInt16Test()
{
if (Environment.Is64BitProcess)
Expand Down Expand Up @@ -1022,6 +1025,7 @@ public static void CreateTruncatingFromIntPtrTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void CreateTruncatingFromSByteTest()
{
if (Environment.Is64BitProcess)
Expand Down Expand Up @@ -1231,6 +1235,7 @@ public static void TryCreateFromCharTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void TryCreateFromInt16Test()
{
nint result;
Expand Down Expand Up @@ -1355,6 +1360,7 @@ public static void TryCreateFromIntPtrTest()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/61920", TestPlatforms.iOS | TestPlatforms.tvOS)]
public static void TryCreateFromSByteTest()
{
nint result;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@

<ItemGroup Condition="'$(TargetOS)' == 'iOSSimulator' and '$(TargetArchitecture)' == 'arm64' and '$(RunDisablediOSTests)' != 'true'">
<!-- Functional tests on arm64 simulator have problems with return codes from mlaunch -->
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\$(TargetOS)\Simulator\**\*.Test.csproj" />
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Simulator\**\*.Test.csproj" />
</ItemGroup>

<!-- Excluding all tests for devices until building on helix works properly -->
Expand Down