Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DI external tests for Stashbox #61928

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Update DI external tests for Stashbox #61928

merged 3 commits into from
Nov 30, 2021

Conversation

z4kn4fein
Copy link
Contributor

@z4kn4fein z4kn4fein commented Nov 22, 2021 •
edited
Loading

Hey,

Related to #53919, I've added support for the IServiceProviderIsService interface to Stashbox's MS DI integration and updated the external DI test project, to allow the execution of the related tests.

Thanks!

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 22, 2021
@ghost
Copy link

ghost commented Nov 22, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Hey,

Related to #53919, I've added support for the IServiceProviderIsService interface to Stashbox's MS DI integration and updated the external DI test project to allow the execution of the related tests.

Thanks!

Author: z4kn4fein
Assignees: -
Labels:

area-Extensions-DependencyInjection, community-contribution
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Nov 22, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@eerhardt eerhardt self-assigned this Nov 30, 2021
eerhardt
eerhardt approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for CI to go green and then I'll merge.

@eerhardt
Copy link
Member

Libraries Build windows net48 x86 Release failure is #61687
Libraries Test Run release coreclr windows x64 Debug failures are flakey sockets tests

@eerhardt eerhardt merged commit 9f4486e into dotnet:main Nov 30, 2021
@joshpeterson joshpeterson mentioned this pull request Dec 1, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees

@eerhardt eerhardt

Labels
area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z4kn4fein @dnfadmin @eerhardt