Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endHeader flag to QPACK decode #62059

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

@ghost
Copy link

ghost commented Nov 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@JamesNK
Copy link
Member

JamesNK commented Nov 25, 2021

This change makes QPACK's Decode method consistent with HPACK's by adding an endHeaders argument.

The bool argument doesn't do anything at the moment but in the future it will be used to validate that headers were completely read when endHeaders is true. Today QPACK header data could be truncated to an invalid state and the consuming app wouldn't be notified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync
3 participants