Revert "Adding support for the X86Base.Pause intrinsic on Mono (#61707)" #62157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
requested review from
imhameed,
lambdageek,
SamMonoRT and
vargaz
as code owners
|
FYI @tannergooding it looks like these tests are still failing in CI, reverting for now |
jkoritzinsky
approved these changes
Nov 29, 2021
|
Someone on the Mono team likely needs to join in and help diagnose the issue then. It's not clear what's causing the failure on Mono to me, particularly where the relevant support was added and it was passing locally on my box. |
This was referenced Nov 30, 2021
I'll take a look (likely early next week). Is there an open issue tracking this? |
|
I think the patch is good, but its only implemented when running with --llvm. |
|
Yea, I'd start by un-reverting the patch, but move the issues.targets ExcludeList item so that it doesn't run on mini JIT, interp, non-LLVM AOT, etc. /cc @fanyang-mono |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1997bee.
Looks like these tests are still failing after the change.