Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SuperPMI temp filename creation #62169

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Improve SuperPMI temp filename creation #62169

merged 2 commits into from
Dec 1, 2021

Conversation

BruceForstall
Copy link
Member

  1. Disallow all non-ASCII characters from the MC filename.
  2. Disallow ( and ) in filenames.
  3. To improve uniqueness, always append an 8-character random number
    to the filename.

@BruceForstall
Improve SuperPMI temp filename creation
668f57c 
1. Disallow all non-ASCII characters from the MC filename.
2. Disallow `(` and `)` in filenames.
3. To improve uniqueness, always append an 8-character random number
to the filename.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2021
@ghost
Copy link

ghost commented Nov 30, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Disallow all non-ASCII characters from the MC filename.
  2. Disallow ( and ) in filenames.
  3. To improve uniqueness, always append an 8-character random number
    to the filename.
Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall
Copy link
Member Author

@kunalspathak @dotnet/jit-contrib PTAL

kunalspathak
kunalspathak approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit 4cf4661 into dotnet:main Dec 1, 2021
@BruceForstall BruceForstall deleted the FixSpmiNameMunging branch December 1, 2021 00:18
@joshpeterson joshpeterson mentioned this pull request Dec 1, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @kunalspathak