Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: rework logic for when OSR imports method entry #63406

Merged
merged 1 commit into from
Jan 11, 2022
Merged

JIT: rework logic for when OSR imports method entry #63406

merged 1 commit into from
Jan 11, 2022

Commits on Jan 5, 2022

  1. JIT: rework logic for when OSR imports method entry 

    OSR wasn't aggressive enough in importing the original method entry,
so if an inlinee introduced a recursive tail call that we wanted to
turn into a loop, we might find that the target block for the loop
branch never got created.

Update the logic so that we import the entry if we're in the root
method and we have an inlineable call in tail position. This will
over-import in many cases but if those blocks turn out to be unreachable
they will usually be removed without impacting final code gen.

Fixes one of the OSR stress mode failures seen in dotnet#62980.
    @AndyAyersMS
    AndyAyersMS committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    718452d View commit details
    Browse the repository at this point in the history