-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip flaky DllImport tests on Mac #63636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the failures are all for the TestTargetFramework.Core
cases? We might want to just disable those instead of all cases.
Do we run desktop framework tests on Mac via Mono? If so, yeah this might be a bit broad. |
runtime/src/libraries/System.Runtime.InteropServices/tests/DllImportGenerator.UnitTests/Compiles.cs Line 315 in 695fb1e
|
No, we do not. DllImport tests are crashing on Linux - the test failed in |
@jkotas The linux musl failure looks a lot different than the Mac failure mode, which looks like it's failing to set up the correct Compilation for Roslyn (missing references). Could these be two different failures? |
It is hard to tell whether they are two separate bugs, or whether it is one bug with different failure modes. The DllImport test failures on Mac are intermittent. It is possible that the GC hole can manifest as either data corruption (caused test to fail on Mac) or crash (on Linux). |
Luckily it looks like we have a dump from the linux failure. @jkoritzinsky @elinor-fung Could you take a look and see if you can trace down the failure cause? |
I'll take a look and see what I can figure out. |
Here's the stack trace (from analyzing it in Windbg):
The segfault is due to the |
DllImport crashed on Linux in #63734 . |
@jkoritzinsky Do you plan to debug this GC hole further? |
I'm currently trying to get a repro dump with a longer stresslog. The one I got overnight didn't have a long enough stresslog to get any useful information. Should hopefully have something in a few hours. |
I think the repro on Linux_musl was due to GC Regions based on the dumps I tried to investigate, so I don't think I have any more investigating I can get done here easily without having a Mac. |
DllImportGenerator.UnitTests are disabled on osx-arm64 and we have reverted the GC regions change that should be responsible for the rest of the failures. This fine-grained disablement should not be needed anymore. |
No description provided.