Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #64376

Closed
wants to merge 6 commits into from
Closed

[main] Update dependencies from dotnet/arcade #64376

wants to merge 6 commits into from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 27, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20220130.1
  • Date Produced: January 30, 2022 2:37:04 PM UTC
  • Commit: 4d6406fa2e84c8516a338694be3a4097e6e1f104
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
bfb3d1a 
…126.9

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22075.6 -> To Version 2.5.1-beta.22076.9
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
e3a8136 
…127.8

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22075.6 -> To Version 2.5.1-beta.22077.8
@premun
Copy link
Member

premun commented Jan 28, 2022

FYI we split arcade updates out into its own PR and are testing ignoring the skipped checks so that PRs can be auto-merged again

dotnet-maestro bot and others added 3 commits January 29, 2022 13:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
0bc38cf 
…128.2

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22075.6 -> To Version 2.5.1-beta.22078.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
e9045a7 
…130.1

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22075.6 -> To Version 2.5.1-beta.22080.1
@akoeplinger
Merge branch 'main' into darc-main-10eb29b9-daec-4463-98b5-b613fbbe7c5e
19c261c
@akoeplinger
Copy link
Member

The failures in runtime (Build windows x64 release NativeAOT) and runtime (Mono llvmfullaot Pri0 Runtime Tests Run Linux x64 release) are genuine, e.g. seems to be the same issue:

EXEC : error : Failed to load type 'Microsoft.CodeAnalysis.ISourceGenerator' from assembly 'Microsoft.CodeAnalysis, Version=1.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' [D:\a\_work\1\s\artifacts\tests\coreclr\windows.x64.Release\Tests\Core_Root\nativeaot\build\BuildFrameworkNativeObjects.proj]
  Internal.TypeSystem.TypeSystemException+TypeLoadException: Failed to load type 'Microsoft.CodeAnalysis.ISourceGenerator' from assembly 'Microsoft.CodeAnalysis, Version=1.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
     at Internal.TypeSystem.ThrowHelper.ThrowTypeLoadException(ExceptionStringID id, String typeName, String assemblyName)
     at Internal.TypeSystem.ResolutionFailure.Throw()
     at Internal.TypeSystem.Ecma.EcmaModule.GetType(EntityHandle handle)
     at Internal.TypeSystem.Ecma.EcmaType.InitializeImplementedInterfaces()
     at ILCompiler.Metadata.Transform`1.InitializeTypeDef(MetadataType entity, TypeDefinition record)
     at ILCompiler.Metadata.Transform`1.HandleType(TypeDesc type)
     at ILCompiler.Metadata.MetadataTransform.Run[TPolicy](TPolicy policy, IEnumerable`1 modules)
     at ILCompiler.GeneratingMetadataManager.ComputeMetadata[TPolicy](TPolicy policy, NodeFactory factory, Byte[]& metadataBlob, List`1& typeMappings, List`1& methodMappings, List`1& fieldMappings, List`1& stackTraceMapping)
     at ILCompiler.UsageBasedMetadataManager.ComputeMetadata(NodeFactory factory, Byte[]& metadataBlob, List`1& typeMappings, List`1& methodMappings, List`1& fieldMappings, List`1& stackTraceMapping)
     at ILCompiler.DependencyAnalysis.MetadataNode.GetData(NodeFactory factory, Boolean relocsOnly)
     at ILCompiler.DependencyAnalysis.ObjectWriter.EmitObject(String objectFilePath, IReadOnlyCollection`1 nodes, NodeFactory factory, ObjectWritingOptions options, IObjectDumper dumper, Logger logger)
     at ILCompiler.RyuJitCompilation.CompileInternal(String outputFile, ObjectDumper dumper)
     at ILCompiler.Compilation.ILCompiler.ICompilation.Compile(String outputFile, ObjectDumper dumper)
     at ILCompiler.Program.Run(String[] args)
     at ILCompiler.Program.Main(String[] args)

and

aot-compile: compiling /__w/1/s/artifacts/tests/coreclr/Linux.arm64.Release/Tests/Core_Root/System.Private.CoreLib.Generators.dll; MONO_PATH: /__w/1/s/artifacts/tests/coreclr/Linux.arm64.Release/Tests/Core_Root:/__w/1/s/artifacts/tests/coreclr/Linux.arm64.Release/Tests/Core_Root
  Failed to load method 0x6000022 from '/__w/1/s/artifacts/tests/coreclr/Linux.arm64.Release/Tests/Core_Root/System.Private.CoreLib.Generators.dll' due to Could not resolve type with token 01000025 from typeref (expected class 'Microsoft.CodeAnalysis.ISourceGenerator' in assembly 'Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35') assembly:Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35 type:Microsoft.CodeAnalysis.ISourceGenerator member:(null).

@akoeplinger
Copy link
Member

@MichalStrehovsky any idea why this might be happening? nothing from the arcade changes jump out at me.

@ViktorHofer FYI this is the same issue you're hitting in #64670

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky any idea why this might be happening? nothing from the arcade changes jump out at me.

I don't see System.Private.CoreLib.Generators.dll in CORE_ROOT on my box, so the problem is in that. Source generators have no business to be in CORE_ROOT. I've fixed something similar in #62836 so this might be the same problem. It's a mystery why this became a problem now.

I've submitted #64715 that will fix this for the NativeAOT leg because the compiler should not crash on this.

@akoeplinger akoeplinger mentioned this pull request Feb 3, 2022
Merged
@ViktorHofer
Copy link
Member

#64670 contains the fix to not populate libraries' runtime path with the CoreLib source generator: #64670. Sorry for the inconvenience.

@MichalStrehovsky
Copy link
Member

#64670 contains the fix to not populate libraries' runtime path with the CoreLib source generator: #64670. Sorry for the inconvenience.

It found a good bug in the AOT compiler, so no inconvenience :)! Thank you!

@akoeplinger
Merge remote-tracking branch 'upstream/main' into darc-main-10eb29b9-…
42b6cb5 
…daec-4463-98b5-b613fbbe7c5e

# Conflicts:
#	eng/Version.Details.xml
#	eng/Versions.props
#	global.json
@ViktorHofer
Copy link
Member

Note that arcade is also being updated in #64678

@akoeplinger
Copy link
Member

Yeah, closing this in favor of #64678

@akoeplinger akoeplinger closed this Feb 3, 2022
@akoeplinger akoeplinger deleted the darc-main-10eb29b9-daec-4463-98b5-b613fbbe7c5e branch February 3, 2022 14:45
@premun
Copy link
Member

premun commented Feb 3, 2022

Note that arcade is also being updated in #64678

Yeah, we are aware actually. We have been changing the Maestro subscriptions merge policies for dotnet/runtime and we were originally testing it on Arcade which we separated out.
We changed the repo-wide policies yesterday and set batchable to true again on Arcade

@ghost ghost locked as resolved and limited conversation to collaborators Mar 5, 2022
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Apr 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@premun premun premun approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@premun @akoeplinger @MichalStrehovsky @ViktorHofer @danmoseley