Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Fix downcast check in Array.CopySlow #64469

Merged
merged 2 commits into from
Jan 30, 2022
Merged

[mono] Fix downcast check in Array.CopySlow #64469

merged 2 commits into from
Jan 30, 2022

Commits on Jan 28, 2022

  1. Add regression test for object[] -> Int32Enum[] array copy 

    where each element in the source array is the appropriate type
    @lambdageek
    lambdageek committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    f6c98dc View commit details
    Browse the repository at this point in the history

  2. Fix downcast check in slow array copy 

    When we have to resort to checking element by element, compare the type of each
actual element with the destination type. In particular, not the destinations
underlying type when it's an enum - we don't want to allow unrelated enums
using the same representation to copy over.

Fixes dotnet#64387
    @lambdageek
    lambdageek committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    9b34851 View commit details
    Browse the repository at this point in the history