Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that StressLogAnalyzer works with filtering 64 bit addresses #64594

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Feb 1, 2022

The bug was a typo, I should have used strtoull instead of strtoul. The latter only works with 32-bit integers.

In this change, I added a -a mode for dumping all messages, just in case we need to debug similar situations again.

@cshung cshung self-assigned this Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

The bug was a typo, I should have used strtoull instead of strtoul. The latter only works with 32-bit integers.

In this change, I added a -a mode for dumping all messages, just in case we need to debug similar situations again.

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

Copy link
Contributor

@PeterSolMS PeterSolMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add the new option to the Usage() function as well?

@cshung cshung changed the title Make sure that StressLogAnalyzer works with filtering 64 bit addresses [WIP] Make sure that StressLogAnalyzer works with filtering 64 bit addresses Feb 2, 2022
@cshung cshung changed the title [WIP] Make sure that StressLogAnalyzer works with filtering 64 bit addresses Make sure that StressLogAnalyzer works with filtering 64 bit addresses Feb 2, 2022
@cshung cshung merged commit 9a104b6 into dotnet:main Mar 4, 2022
@cshung cshung deleted the public/stress-64 branch March 4, 2022 18:07
@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants