Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account zero-offset field sequences when propagating locals #64701

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Take into account zero-offset field sequences when propagating locals #64701

merged 3 commits into from
Feb 8, 2022

Commits on Feb 5, 2022

  1. Add a test

    @SingleAccretion
    SingleAccretion committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    0043081 View commit details
    Browse the repository at this point in the history

  2. Fix the problem 

    LCL_VAR use VN != VN of its SSA def.

Using one for replacement can run afoul of substituting
into a LCL_VAR that has a zero-offset field sequence on
top and thus duplicate the sequence (as the replacement
def will already have this sequence incorporated into its
VN).
    @SingleAccretion
    SingleAccretion committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    fd76f2c View commit details
    Browse the repository at this point in the history

  3. Fix the same problem in local propagation 

    Just one diff, missing null check elimination: we propagated a field
sequence for an array address (PtrToArrElem) that later wasn't recognized
as implying non-nullness of another PtrToArrElem to the same array.
    @SingleAccretion
    SingleAccretion committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    c63988c View commit details
    Browse the repository at this point in the history