Clear GC info when consuming GT_PUTARG_SPLIT nodes #65432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT |
|
/azp run runtime-coreclr jitstressregs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Lots of failures due to "The response contained an invalid status code 500 Internal Server Error"... will retry the jitstressregs job. |
| @@ -1807,7 +1807,6 @@ void CodeGen::genConsumePutStructArgStk(GenTreePutArgStk* putArgNode, | |||
| #if FEATURE_ARG_SPLIT | |||
| //------------------------------------------------------------------------ | |||
| // genConsumeArgRegSplit: Consume register(s) in Call node to set split struct argument. | |||
| // Liveness update for the PutArgSplit node is not needed | |||
There was a problem hiding this comment.
Can you update the method name in the comment?
There was a problem hiding this comment.
Sure, but let me do it as part of another change to avoid rerunning CI.
|
cc @dotnet/jit-contrib for another opportunity for comments/suggestions before I merge this. |
BruceForstall
approved these changes
Feb 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #65395