Run trim analyzer #65870
Run trim analyzer #65870
Conversation
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
sbomer
added
NO-MERGE
src/libraries/System.Reflection.Context/src/System.Reflection.Context.csproj
Outdated
Show resolved
Hide resolved
| using System.Runtime.CompilerServices; | ||
|
|
||
| namespace System.Reflection.Runtime.Dispensers | ||
| { | ||
| internal sealed class DispenserThatReusesAsLongAsKeyIsAlive<K, V> : Dispenser<K, V> | ||
| internal sealed class DispenserThatReusesAsLongAsKeyIsAlive<K, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] V> : Dispenser<K, V> |
There was a problem hiding this comment.
@MichalStrehovsky I'm not familiar enough with nativeaot to know why this wasn't warning (in the use of ConditionalWeakTable<K, V> below) in nativeaot - do you have any ideas?
There was a problem hiding this comment.
IIRC warnings for generic dataflow are not implemented. I scoped out some of the warnings because it's not critical for functionality. One person working on dataflow part time on NativeAOT side is no match to several people working on this pretty much full time on the IL Linker side.
We'll be able to re-use the unit tests on the IL Linker side to bring this to parity once this becomes a priority.
sbomer
removed
the
NO-MERGE
...ibraries/System.Private.Xml/src/System/Xml/Serialization/ReflectionXmlSerializationReader.cs
Outdated
Show resolved
Hide resolved
Use pragma instead of UnconditionalSuppressMessage
|
Failures are #66143 |
ghost
locked as resolved and limited conversation to collaborators
No description provided.