-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add armv8l virtualized 32-bit ARM core detection #66477
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsExpected behaviorRuntime should be able to build within 32-bit userspace on 64-bit ARM cores. Actual behaviorPer dotnet/source-build#2781, runtime does not know to parse as Proposed modificationsThis pull request modifies existing logics to parse VariaParallel merge request on Alpine's side Made as part of Alpine Linux dotnet6 packaging project, see dotnet/source-build#2782
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me. My only concern is that someone could build on an ARMv8 system and it would fail to run on an ARMv7 system. Is that something that can occur with this change?
@jkoritzinsky I don't believe that can occur here. As it happens I already filed an issue similar to this in 2019. dotnet/arcade#4527 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@directhex has more experience in this area and says there's no issue, so I'm okay with the change
@directhex Should I change the logics to cover |
Yeah I think that makes sense so we're ready for runtime/eng/native/configuretools.cmake Line 56 in 458524a
|
I'm ignorant of proper syntax, does |
It's a regex so it'd need to be |
That might be more prudent, indeed. |
Expected behavior
Runtime should be able to build within 32-bit userspace on 64-bit ARM cores.
Actual behavior
Per dotnet/source-build#2781, runtime does not know to parse as
arm
when output ofuname -m
isarmv8l
.Proposed modifications
This pull request modifies existing logics to parse
armv8l
in the same way asarmv7l
.Varia
Parallel merge request on Alpine's side
Arm support on source-build at dotnet/installer#13378
Made as part of Alpine Linux dotnet6 packaging project, see dotnet/source-build#2782