[mono][wasm] Initialize debugger_tls_id on WASM as well.

[vargaz]

Some code paths are using mono_native_tls_get_value () instead of GET_DEBUGGER_TLS ().

[ghost]

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Some code paths are using mono_native_tls_get_value () instead of GET_DEBUGGER_TLS ().

Author:	vargaz
Assignees:	vargaz
Labels:	area-Debugger-mono
Milestone:	-

[vargaz]

Some comments:

• the two init functions should be merged to reduce the chance of similar errors
• maybe use mono_native_tls_get_value () on wasm as well, its not really perf critical and will be needed later for threading support.
• this code gets executed in Release mode as well, is that ok ?

[vargaz]

This was causing (some) of the 3.1.x crashes.

[vargaz]

/azp run runtime-wasm

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[thaystg]

I think it's okay to initialize it, I would like to know which code paths were causing the crashes on 3.1.x, because as far as I remember when I implemented it, the code paths that are being used when debugging on wasm are correctly using the GET_DEBUGGER_TLS.

[vargaz]

debugger_agent_begin_exception_filter () for example. Having two ways to access this seems error prone.

[thaystg]

Yeah, I agree to use "mono_native_tls_get_value () on wasm as well, its not really perf critical and will be needed later for threading support", as you suggested above.
I will add it in my next tasks.

[lewing]

cc @kg

[kg]

I think this works already, but I'll keep it in mind if things break once I get back to eventpipe