Address a few TODOs on S.S.C.Cose. #66641
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsFollow up on #64461 TODOs:
Unaddressed TODOs: Re-evaluate places where we should use Span/Memory/byte[] & Add stream support for content.
|
| => throw new CryptographicException(SR.Format(SR.Sign1UnknownCoseAlgorithm, alg)); | ||
|
|
||
| internal static void ThrowCborNegativeIntegerNotSupported(ulong alg) // Cbor Negative Integer Representation is too big. | ||
| => throw new CryptographicException(SR.Format(SR.Sign1UnknownCoseAlgorithm, BigInteger.MinusOne - new BigInteger(alg))); |
There was a problem hiding this comment.
These are called from only one place, that's not generic, and doesn't appear to be super perf-critical. Why create throw helpers?
There was a problem hiding this comment.
ThrowIfNotSupported already existed in this helper type and I wanted to keep validations centralized for future reference.
* Make HeaderMaps optionals * Improve handling of integers larger/smaller than int32 in Alg header
ghost
locked as resolved and limited conversation to collaborators
bartonjs
added
cryptographic-docs-impact
needs-further-triage
Follow up on #64461 TODOs:
Unaddressed TODOs: Re-evaluate places where we should use Span/Memory/byte[] & Add stream support for content.
They will be addressed in separates PRs respectively.