Revert "Remove 4267 suppression from mono (#66552)" #66719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c3dbdea. This caused `mono-aot-cross.exe` to crash on windows, breaking all the windows/AOT tests. Issue: dotnet#66718
radical
requested review from
lambdageek,
vargaz,
lateralusX,
BrzVlad,
naricc,
SamMonoRT,
thaystg and
marek-safar
as code owners
lewing
approved these changes
Mar 16, 2022
|
/azp run runtime-wasm |
|
Tagging subscribers to 'arch-wasm': @lewing |
|
cc @am11 |
|
This should fix it: #66721 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
added
the
NO-MERGE
|
If #66721 passes, then this PR will be closed. Waiting on that. |
|
#66721 passed, closing. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c3dbdea.
This caused
mono-aot-cross.exeto crash on windows, breaking all thewindows/AOT tests.
Corresponding issue: #66718