Allow null-based ARR_ADDRs
#67486
Merged
Allow null-based ARR_ADDRs
#67486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can sometimes see trees like "ARR_ADDR(long 0)" that are the result of morph's folding logic. In general it does not seem great to allow folding of BYREFs into LONGs like that, but it is also not incorrect per-se.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe can sometimes see trees like In general it does not seem great to allow folding of Should fix stress failures introduced in #64581.
|
|
@dotnet/jit-contrib I would like to request |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Apr 2, 2022
|
@SingleAccretion jitstress passed. Mark ready for review? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can sometimes see trees like
ARR_ADDR(long 0)that are the result of morph's folding logic.In general it does not seem great to allow folding of
BYREFs intoLONGs like that, but it is also not incorrect per-se.Should fix stress failures introduced in #64581.