Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [Mono] Fix uninitialized vtable bug #67759

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 8, 2022

Backport of #67746 to release/6.0

/cc @lambdageek @simonrozsival

Customer Impact

This PR fixes a crash in .NET MAUI on Android (#67402).

Testing

The PR contains a functional test.

Risk

Low risk. The fix is simple and it is tested.

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Apr 8, 2022
@lambdageek lambdageek added this to the 6.0.x milestone Apr 8, 2022
@jahmai-ca
Copy link

I am dealing with this exact issue while doing an preliminary port of our Android Xam apps to net6 MAUI. How is this expected to make it out to devs, via a VS 2022 update or a NET6 SDK update or both? Any idea when that might be? Thanks :)

@lambdageek lambdageek added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 11, 2022
@lambdageek
Copy link
Member

Related PR in main had some tvOS failures. Hold off on this one while we investigate.

@lambdageek lambdageek removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 11, 2022
@lambdageek
Copy link
Member

tvOS crashes weren't due to this PR. they were masked by an xharness issue

@leecow leecow removed the Servicing-consider Issue for next servicing release review label Apr 12, 2022
@leecow leecow modified the milestones: 6.0.x, 6.0.5 Apr 12, 2022
@carlossanlop
Copy link
Member

@leecow did you mean to add the servicing-approved label?

@leecow leecow added the Servicing-approved Approved for servicing release label Apr 13, 2022
@carlossanlop carlossanlop merged commit c3fcafb into release/6.0 Apr 13, 2022
@jkotas jkotas deleted the backport/pr-67746-to-release/6.0 branch April 16, 2022 00:38
@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants