Add support for storing method handle histograms in profiles #67919
Conversation
Allow method handle histograms in .mibc files and in the PGO text format. Contributes to dotnet#44610.
jakobbotsch
force-pushed
the
method-handle-histograms
branch
from
ec36d86
to
26ad0a8
Compare
ghost
assigned 
|
Do you need to change the JIT-EE GUID? |
I have some follow-up changes that will actually start producing and using the new kind of PGO data. I think we can delay updating the JIT-EE GUID to that as just adding new PGO schema kinds should be binary compatible (and my future changes will probably also need another JIT-EE GUID update). |
|
@jakobbotsch Yes, this requires a bump in the R2R minor version. |
|
@jakobbotsch Have you verified that with these changes the dotnet-pgo tool continues to work with .NET 6 runtimes? |
Is it ok to wait until future changes that actually start producing and consuming these? At that point I will add something similar to
Yes, it produced a .mibc with the same hash as dotnet-pgo from current main in my test. |
|
When in doubt, bump the version. If there is no chance that new data could be produced, you don't need to, but bumping the R2R version is pretty cheap, and doesn't come with significant costs as old R2R code should not be broken. |
|
@davidwrighton I've bumped the R2R minor version and also the JIT-EE GUID to be safe, please take another look. |
|
ping @davidwrighton, anything else you think I should do here? |
|
Ping @davidwrighton, my follow-up depends on this one. |
Allow method handle histograms in .mibc files and in the PGO text format.
Contributes to #44610.
@davidwrighton would this in theory need a R2R version bump? I suppose we can wait with such a bump until we actually start producing profiles with this data (at which point we should also add an equivalent of
GetLikelyClass)?cc @dotnet/jit-contrib