JIT: fix assert seen in some OSR cases #68048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of dotnet#67884, OSR compilations were looking at data in the `gsShadowVarInfo` array in cases where it was not initialized. Fix is to defer allocating the `gsShadowVarInfo` array until it's certain it will be initialized. Fixes dotnet#68003.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsAs a result of #67884, OSR compilations were looking at data in the Fix is to defer allocating the Fixes #68003.
|
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Got an OSX repro, finally. The proposed fix above is not fixing the assert. |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
72 tasks
|
@BruceForstall PTAL |
BruceForstall
approved these changes
Apr 15, 2022
Yeah, I think it was... odd that that did not lead to any observable problem. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #67884, OSR compilations were looking at data in the
gsShadowVarInfoarray in cases where it was not initialized.Fix is to null out
gsShadowVarInfoarray if there are no shadowed params.Fixes #68003.