Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate the DAC table on Windows with MSVC linker directives instead of resource injection #68065

Merged
merged 18 commits into from
May 12, 2022
Merged

Generate the DAC table on Windows with MSVC linker directives instead of resource injection #68065

merged 18 commits into from
May 12, 2022

Commits on Apr 7, 2022

  1. Refactor out symbol name for the dac table to be defined by a macro c… 

    …onstant
    @jkoritzinsky
    jkoritzinsky committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    332a64f View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Convert to use an entirely-C++ DacTable. 

    Today it still loads dynamically, so we need to fix that or delay when SOS loads.
    @jkoritzinsky
    jkoritzinsky committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d168ebd View commit details
    Browse the repository at this point in the history

  2. Get the dac table building statically by specially handling the Volat… 

    …ile scenario.

Things are still broken, but they're at least loading correctly now.
    @jkoritzinsky
    jkoritzinsky committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    a066966 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Go back to using RVAs

    @jkoritzinsky
    jkoritzinsky committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    381b816 View commit details
    Browse the repository at this point in the history

  2. RVA calculation can't be done statically, go back to global addresses.

    @jkoritzinsky
    jkoritzinsky committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    bef67f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Fix two stragglers to use the provided DAC table addresses as globals… 

    … and not as RVAs
    @jkoritzinsky
    jkoritzinsky committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    4640ac0 View commit details
    Browse the repository at this point in the history

  2. Remove DacTableGen and all related infrastructure

    @jkoritzinsky
    jkoritzinsky committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    03b27f2 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @jkoritzinsky
    jkoritzinsky authored Apr 15, 2022
    Configuration menu
    Copy the full SHA
    b42ab98 View commit details
    Browse the repository at this point in the history

  4. Fix linux build

    @jkoritzinsky
    jkoritzinsky committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    3c20940 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. PR feedback

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    f81fd85 View commit details
    Browse the repository at this point in the history

  2. Fix some of the build breaks.

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    5dbfc33 View commit details
    Browse the repository at this point in the history

  3. Move symbol def.

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    572d12a View commit details
    Browse the repository at this point in the history

  4. Fix name lookup for win-x86

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d6e4f52 View commit details
    Browse the repository at this point in the history

  5. Handle any size symbol name up to UINT32_MAX

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ff964bb View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge branch 'main' of github.com:dotnet/runtime into no-dactablegen

    @jkoritzinsky
    jkoritzinsky committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    07a645b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Fix dactable initialization on non-Windows.

    @jkoritzinsky
    jkoritzinsky committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f872c55 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Make the "target process dac table" reading be dac-instance specific … 

    …(so once per target) instead of dac-library specific (once per coreclr build version).

We need to read the values once per process to ensure that child processes with ASLR enabled (which as a result will have the DAC table entries point to different addresses) don't break debugging later processes.
    @jkoritzinsky
    jkoritzinsky committed May 11, 2022
    Configuration menu
    Copy the full SHA
    f23977b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into no-dactablegen

    @jkoritzinsky
    jkoritzinsky committed May 11, 2022
    Configuration menu
    Copy the full SHA
    41f5bcc View commit details
    Browse the repository at this point in the history