Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationBinder handles ISet<> #68133

Merged
merged 28 commits into from
Jul 19, 2022
Merged

ConfigurationBinder handles ISet<> #68133

merged 28 commits into from
Jul 19, 2022

Commits on Jul 18, 2022

  1. First pass

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    871166c View commit details
    Browse the repository at this point in the history

  2. Remove commented code

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    3fe8714 View commit details
    Browse the repository at this point in the history

  3. Support IReadOnlySet. Refactor out method that determines most suitab… 

    …le type for collections that are already specified in the destination.
    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    65ea989 View commit details
    Browse the repository at this point in the history

  4. Handles ISet after rebase. Still to do IReadOnlySet

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    c2d1038 View commit details
    Browse the repository at this point in the history

  5. Add support back for IReadOnlySet

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    2613c44 View commit details
    Browse the repository at this point in the history

  6. PR feedback - pre-allocate just one array instead of many allocations… 

    … in a loop
    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b377ac1 View commit details
    Browse the repository at this point in the history

  7. All tests pass.

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    10e6238 View commit details
    Browse the repository at this point in the history

  8. Tidy

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    c8e7b60 View commit details
    Browse the repository at this point in the history

  9. Skips custom sets

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ef33f6f View commit details
    Browse the repository at this point in the history

  10. Strip out unused code

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    accbc13 View commit details
    Browse the repository at this point in the history

  11. Tidy up and remove dead code.

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    92afd9a View commit details
    Browse the repository at this point in the history

  12. Tidy up tests

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    3687886 View commit details
    Browse the repository at this point in the history

  13. Tidy up comments

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    3c65aa4 View commit details
    Browse the repository at this point in the history

  14. Copy over @halter73's changes

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ee0b40b View commit details
    Browse the repository at this point in the history

  15. Copy over @halter73's changes

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    6b6f6cd View commit details
    Browse the repository at this point in the history

  16. Copy over @halter73's changes

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    6efcd54 View commit details
    Browse the repository at this point in the history

  17. Added restrictions and some tests for set keys being string/enum only

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    3454939 View commit details
    Browse the repository at this point in the history

  18. PR feedback re. preprocessor directive

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    686192e View commit details
    Browse the repository at this point in the history

  19. Started on instantiated dictionary feedback

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b9a9f3a View commit details
    Browse the repository at this point in the history

  20. First pass at cloning dictionary<,>

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    32609c8 View commit details
    Browse the repository at this point in the history

  21. Can now bind (overwrite) to an existing concrete dictionary

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1310ebd View commit details
    Browse the repository at this point in the history

  22. Refactor out common code for binding to existing dictionary. Added te… 

    …sts.
    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    da49d5b View commit details
    Browse the repository at this point in the history

  23. Comments and more tests

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    3f359f4 View commit details
    Browse the repository at this point in the history

  24. Add explicit (separate) test for binding to non-instantiated IReadOnl… 

    …yDictionary
    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    c015c01 View commit details
    Browse the repository at this point in the history

  25. PR feedback - add tests

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    93cf8c0 View commit details
    Browse the repository at this point in the history

  26. PR feedback: introdcue variable for `typeIsADictionaryInterface'

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1667f86 View commit details
    Browse the repository at this point in the history

  27. PR feedback

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ca1defe View commit details
    Browse the repository at this point in the history

  28. Fix rebase issues

    @SteveDunn
    SteveDunn committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    72be954 View commit details
    Browse the repository at this point in the history