Allow custom attribute filtering with an open generic type. #68158
+74
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtering on an open generic type retrieves all attributes that are or are derived from constructed instances of that type. fix dotnet#64169
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsFiltering on an open generic type retrieves all attributes that are or fix #64169
|
|
@buyaa-n do any of the failures above look "real" to you? |
Not sure what you mean by "real", but the failures looks unrelated. Anyway assume your PR is not ready as it is a draft |
|
@buyaa-n thanks. I was just looking for confirmation that I shouldn't be diving deeper into the check failures. I've removed the draft status. |
madelson
commented
Apr 19, 2022
...em.Private.CoreLib/src/Internal/Reflection/Extensions/NonPortable/CustomAttributeSearcher.cs
Show resolved
Hide resolved
buyaa-n
reviewed
Apr 20, 2022
buyaa-n
approved these changes
Apr 20, 2022
jkotas
approved these changes
Apr 21, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering on an open generic type retrieves all attributes that are or
are derived from constructed instances of that type.
fix #64169