Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryData.Empty.ToString throws ArgumentNullException #68349

Merged
merged 2 commits into from
Apr 22, 2022
Merged

BinaryData.Empty.ToString throws ArgumentNullException #68349

merged 2 commits into from
Apr 22, 2022

Conversation

pedrobsaila
Copy link
Contributor

Fixes #68262

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 21, 2022
@ghost
Copy link

ghost commented Apr 21, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68262

Author: pedrobsaila
Assignees: -
Labels:

area-System.Memory
Milestone: -

jkotas
jkotas approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

adamsitnik
adamsitnik approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution @pedrobsaila !

@runfoapp runfoapp bot mentioned this pull request Apr 21, 2022
Closed
@stephentoub
Copy link
Member

Failure is #68357

@stephentoub stephentoub merged commit a685d88 into dotnet:main Apr 22, 2022
@pedrobsaila pedrobsaila deleted the 68262 branch April 22, 2022 06:20
@ghost ghost locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BinaryData.Empty.ToString throws ArgumentNullException
4 participants
@pedrobsaila @stephentoub @adamsitnik @jkotas