Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unmanaged AssemblyName parser #68737

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 30, 2022

Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib

@ghost
Copy link

ghost commented Apr 30, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib

Author: jkotas
Assignees: jkotas
Labels:

area-AssemblyLoader-coreclr

Milestone: -

@jkotas jkotas added NO-REVIEW Experimental/testing PR, do NOT review it and removed area-AssemblyLoader-coreclr labels Apr 30, 2022
@jkotas
Copy link
Member Author

jkotas commented Apr 30, 2022

Depends on #68735

@ghost
Copy link

ghost commented Apr 30, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib

Author: jkotas
Assignees: jkotas
Labels:

NO-REVIEW, area-AssemblyLoader-coreclr

Milestone: -

@jkotas jkotas removed the NO-REVIEW Experimental/testing PR, do NOT review it label May 1, 2022
@jkotas jkotas marked this pull request as ready for review May 1, 2022 14:43
@jkotas jkotas requested review from VSadov and removed request for MichalStrehovsky May 1, 2022 14:43
Replaced the few places that need to parse assembly names in the VM with callbacks to CoreLib
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@jkotas jkotas merged commit 6d0bcc4 into dotnet:main May 3, 2022
@jkotas jkotas deleted the assemblyname-parser branch May 3, 2022 03:35
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants