Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case to update loop tables when preheader is removed #68803

Merged
merged 2 commits into from
May 10, 2022
Merged

Handle case to update loop tables when preheader is removed #68803

merged 2 commits into from
May 10, 2022

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented May 3, 2022 •
edited
Loading

Context: #68756 (comment)

Fixes: #68756

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 3, 2022
@ghost ghost assigned kunalspathak May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #68756

Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@kunalspathak kunalspathak mentioned this pull request May 3, 2022
Closed
@kunalspathak kunalspathak mentioned this pull request May 3, 2022
Closed
@kunalspathak
Copy link
Member Author

There are diffs that occurs because we have stopped down scaling the loop blocks in certain cases.

@jakobbotsch
Copy link
Member

@dotnet/jit-contrib

@kunalspathak
Copy link
Member Author

Ping. Can someone review this to unblock the clean libraries-jitstress?

jakobbotsch
jakobbotsch approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but am not familiar with the code.

BruceForstall
BruceForstall approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It feels like this unmarking / unscaling still needs to be made more robust somehow.

@kunalspathak
Copy link
Member Author

It feels like this unmarking / unscaling still needs to be made more robust somehow.

Opened #68844 to track it.

@kunalspathak kunalspathak merged commit 8d420f4 into dotnet:main May 10, 2022
@kunalspathak kunalspathak deleted the loop_fixes branch May 10, 2022 16:37
@jakobbotsch jakobbotsch mentioned this pull request May 10, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault inside JIT in libraries-jitstress
3 participants
@kunalspathak @jakobbotsch @BruceForstall