-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Don't fail the CI job if Firefox tests fail in runtime-wasm
#69615
Conversation
Tagging subscribers to this area: @directhex Issue Details.. since they are known to be unstable currently. Having the Firefox job be red because some tests failed is not useful, because it can happen on any PR that runs
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details.. since they are known to be unstable currently. Having the Firefox job be red because some tests failed is not useful, because it can happen on any PR that runs
|
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
… known to be unstable currently
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
runtime-wasm
runtime-wasm
runtime-wasm
/azp run runtime-wasm,runtime-extra-platforms |
Azure Pipelines failed to run 2 pipeline(s). |
This reverts commit 849760c.
/azp run runtime-wasm,runtime-extra-platforms |
Azure Pipelines successfully started running 2 pipeline(s). |
The unrelated AOT build failure is likely #69653 . |
I'm looking at that right now. If I don't figure out a solution soon, then I'll revert it. |
Debugger tests running on Firefox are known to be unstable right now. So, they can fail on unrelated PRs.
When they are run on
runtime-staging
, the test failures don't mark the whole job as failed.But when they run on
runtime-wasm
, they do. And this shows up as failed in GitHub checks view, which is not helpful.