-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move macOS remote unwinding to libunwind directory #69720
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsWe were duplicating headers between Windows and macOS remote unwind code. This PR applies upstream patch from libunwind/libunwind#365 and adjusts our local cmake configs to deduplicate the code.
|
cc @janvorli, @AaronRobinsonMSFT, @jkotas |
49fff60
to
e0b95db
Compare
@am11 I think we are just waiting to see if the upstream changes get taken. I like the clean-up for sure. Any concerns about upstream acceptance? |
@AaronRobinsonMSFT, in the past, we have upstreamed in parallel like this. It is totally reasonable to hold this PR until upstream one is reviewed/merged. There is no rush. I am planning on upstreaming two remaining items after this:
|
Glad we are on the same page. That is really the only reason I haven't merged this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! I am sorry for the big delay, my github account somehow decided that my email is no longer valid and stopped sending me notifications on comments / PR requests and I've missed this one.
@am11 Seems like the libunwind changes were merged into main. Let's make sure this is still green and then get it in. |
The changes made in upstream directory |
4854ee3
to
7c751ae
Compare
@AaronRobinsonMSFT, upstream PR is merged now. |
We were duplicating headers between Windows and macOS remote unwind code. This PR applies upstream patch from libunwind/libunwind#365 and adjusts our local cmake configs to deduplicate the code.