Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-preview5] Revert "[mono][interp] Add tiering within interpreter (#68823)" #69866

Merged
merged 2 commits into from
Jun 1, 2022
Merged

[release/7.0-preview5] Revert "[mono][interp] Add tiering within interpreter (#68823)" #69866

merged 2 commits into from
Jun 1, 2022

Conversation

radical
Copy link
Member

@radical radical commented May 26, 2022 •
edited
Loading

This reverts commit 962a455.

Prompted by #69864, and #69868 .

@ghost
Copy link

ghost commented May 26, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit 962a455.

Prompted by #69864

Author: radical
Assignees: -
Labels:

arch-wasm, area-Codegen-Interpreter-mono
Milestone: -

@ghost ghost assigned radical May 26, 2022
@radical radical changed the title Revert "[mono][interp] Add tiering within interpreter (#68823)" [release/7.0-preview5] Revert "[mono][interp] Add tiering within interpreter (#68823)" May 26, 2022
@lewing lewing requested a review from marek-safar May 26, 2022 16:43
lewing
lewing approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got pulled into the preview and we'd like to keep it out

@radical radical marked this pull request as ready for review May 26, 2022 17:00
@lewing
Copy link
Member

lewing commented May 26, 2022

@mmitche just a heads up that we want to roll this back out of p5

@radical
Copy link
Member Author

radical commented May 31, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

@radical @lewing this backport needs Tactics approval.

@carlossanlop carlossanlop added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 1, 2022
@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop
Copy link
Member

@radical @lewing there are CI failures. Are they related to this change, or can I merge this?

@radical
Copy link
Member Author

radical commented Jun 1, 2022

The failures seem to be timeouts due to infra issues. Looking at some randomly picked tests, they passed but helix still thinks that they failed.

@carlossanlop carlossanlop merged commit 07b1f72 into dotnet:release/7.0-preview5 Jun 1, 2022
@radical radical deleted the rollback-tiering-p5 branch June 1, 2022 23:00
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrzVlad BrzVlad BrzVlad approved these changes

@lewing lewing lewing approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @lewing @carlossanlop @BrzVlad