Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hot/cold splitting test job to jit-runtime-experimental #69922

Merged
merged 1 commit into from
Jun 7, 2022

Commits on Jun 7, 2022

  1. Fix unwind info when fake-splitting

    Fake-splitting currently breaks stack walks by not generating unwind
    info for cold code. This commit implements unwind info on x86/64 when
    fake-splitting by generating unwind info for the combined hot/cold
    section just once, rather than generating unwind info for the separate
    sections.
    
    For reasons to be investigated, this implementation does not work when
    the code sections are separated by an arbitrary buffer (such as the 4KB
    buffer previously used). Thus, the buffer has been removed from the
    fake-splitting implementation: Now, the hot and cold sections are
    placed contiguously in memory, but the JIT continues to behave as if
    they are arbitrarily far away (for example, by using long branches
    between sections).
    
    Following this fix, fake-splitting no longer requires the GC to be
    suppressed by setting `COMPlus_GCgen0size=1000000`. A test job
    has been added to `runtime-jit-experimental` to ensure
    fake/stress-splitting does not regress.
    Aman Khalid committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    e727fba View commit details
    Browse the repository at this point in the history