-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mop-up changes per Jakob's PR suggestions #70180
Conversation
1) Rename CORINFO_HELP_STATIC_VIRTUAL_AMBIGUOUS_RESOLUTION to CORINFO_HELP_THROW_AMBIGUOUS_RESOLUTION_EXCEPTION and put it next to the other CORINFO_HELP_THROW methods; 2) Add the new helper to CorInfoHelpFunc.cs; 3) Remove the jitinterface member doesFieldBelongToClass; 4) Update the JIT EE GUID. Thanks Tomas Fixes: dotnet#69900
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
Thanks Tomas Fixes: #69900 /cc @dotnet/jit-contrib
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I don't have an opinion on the actual change, however I wonder if it would be ok to delay merging it temporarily? Our benchmark SuperPMI collection is failing due to some kind of un-investigated/un-resolved infrastructure issue (@kunalspathak plans to keep investigating), and if we change the JIT-EE GUID before that is fixed, we will lose having the benchmark test for spmi testing. |
I think that's probably fine -- though one thing to note is that this is a follow-up to #66887 that added a new helper without updating the JIT-EE GUID, so we could potentially have some weird JIT behavior if we end up with mismatched JIT/VM/SPMI collections that use that helper. |
No worries, let me know when / how to proceed with this change, it's not blocking to any of my work assignments. |
The issue @BruceForstall talked about should be fixed now with dotnet/performance#2469, so will merge this. |
Rename CORINFO_HELP_STATIC_VIRTUAL_AMBIGUOUS_RESOLUTION to
CORINFO_HELP_THROW_AMBIGUOUS_RESOLUTION_EXCEPTION and put it next
to the other CORINFO_HELP_THROW methods;
Add the new helper to CorInfoHelpFunc.cs;
Remove the obsolete jitinterface member doesFieldBelongToClass;
Update the JIT EE GUID.
Thanks
Tomas
Fixes: #69900
/cc @dotnet/jit-contrib