Add TarEntry conversion constructors#70325

Merged

carlossanlop merged 47 commits intodotnet:mainfrom carlossanlop:TarConversionConstructors

Jun 21, 2022

+2,038-782

Commits on Jun 20, 2022

ref: Conversion constructors
carlossanlop
committed
src: Conversion constructors
carlossanlop
committed
tests: Conversion constructors
carlossanlop
committed
src: Conversion constructor should call this instead of base
carlossanlop
committed
tests: Verify unseekable stream data can be read after conversion
carlossanlop
committed
Adjust _readerOfOrigin nullability in constructors.
carlossanlop
committed
Move most constructor work to the base class.
carlossanlop
committed
ref: Move TarFormat from TarReader to TarEntry
carlossanlop
committed
ref: Move Format property from TarReader to TarEntry
carlossanlop
committed
src: Move Format property from TarReader to TarEntry
carlossanlop
committed
tests: Move Format property from TarReader to TarEntry
carlossanlop
committed
nit - Remove extra spacing in tests
carlossanlop
committed
src: When converting, only transfer fields available in the new format.
carlossanlop
committed
tests: Verify only supported fields are transferred when converting.
carlossanlop
committed
Revert internal->private for magic and version
carlossanlop
committed
Add boolean arg to PaxTarEntry method that adds atime and ctime
carlossanlop
committed
Make sure back and forth tests create firstt timestamp with a slight difference before the constructor invocation, and move the second timestamp right before the first conversion
carlossanlop
committed
Make _readerOfOrigin private again
carlossanlop
committed
src: Use UtcNow, not Now
carlossanlop
committed
tests: Use UtcNow, not Now. Compare converted DateTimeOffset from double only down to seconds and offset.
carlossanlop
committed
Address feedback for comments.
carlossanlop
committed
Add asserts that verify mtime has a non-default value when it is expected for it to be set to UtcNow.
carlossanlop
committed
Adress feedback for setting field values in PosixTarEntry and TarEntry constructors.
carlossanlop
committed
Remove code that reads atime and ctime from extended attributes and sets it to header._atime and header._ctime.
carlossanlop
committed
Make sure that extended attributes always have an atime and a ctime when writing the entry to an archive. Default value is UtcNow.
carlossanlop
committed
Address feedback around timestamps in tests.
carlossanlop
committed
Add more tests for expected values in extended attributes after writing entry to archive.
carlossanlop
committed
Reuse code for conversion tests.
carlossanlop
committed
Change test comparisons of Assert.True with ">=" to use AssertExtensions.GreaterThanOrEqualTo instead.
carlossanlop
committed
Reduce number of dictionary newing, only do it when the contents are about to be read or something needs to be written into it.
carlossanlop
committed
Avoid returning dateTimeOffset != default, instead return true on success
carlossanlop
committed
Remove redundant assignment of format to header.
carlossanlop
committed
Pass Dictionary<string,string> directly to make use of non-virtual TryGetValue in private code.
carlossanlop
committed
Add tests that verify the default writer format is utilized when calling WriteEntry(string,string?)
carlossanlop
committed
Add overload that takes long for converting number of seconds to DateTimeOffset.
carlossanlop
committed
Address latest suggestions by eerhardt
carlossanlop
committed
Make sure dictionary is initialized once in PaxTarEntry constructor.
carlossanlop
committed
Reuse code for single conversion construction tests and back-n-forth conversion construction tests.
carlossanlop
committed
Invert verification of default case and TarEntryFormat.Unknown in switch in TarWriter.WriteEntry.
carlossanlop
committed
Change "if dictionary is not null" to "Debug.Assert "dictionary is not null" in PaxTarEntry timestamp method.
carlossanlop
committed
Conversion tests should also check expected values of ATime and CTime in Gnu and Pax when converting from Ustar or V7.
carlossanlop
committed
Chop long comment, remove another 'preferred default'.
carlossanlop
committed
Make unseekable conversion tests theories to verify all writer formats.
carlossanlop
committed
Set _prefix to Empty if other is not ustar or pax
carlossanlop
committed
Rename TarWriter archiveFormat parameter to format
carlossanlop
committed
Compare datetime offsets only up to seconds
carlossanlop
committed
Increase fixed point format specifier precision, use test comparison of datetimeoffsets only down to seconds.
carlossanlop
committed