-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wasm] Add support for baseUrl and mainScriptPath #70375
Conversation
See also this #69441 |
} else { | ||
module.mainScriptPath = hr; | ||
} | ||
|
||
(<any>module)["mainScriptUrlOrBlob"] = hr; | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're changing this, it might make sense to have a convention for how to tell the runtime what its baseUrl is so it doesn't have to guess. i'm guessing uno could pipe that through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guessing should be removed - and blazor updated to provide a base URL (and possibly also the URL of the worker script - actually depending on how much stuff they mangle we might need some locate function where we can ask for normal names that we know and blazor can tell us what they mangled them to). the guessing was just a hack because I didn't want to coordinate a pair of aspnetcore and runtime PRs
(I don't mean this current PR should remove the guessing and wait until blazor is updated - that should be done separately)
This change allows for resources like the crypto worker or thread workers to be resolved properly when used in a generic context.
2f23d2d
to
015a8ec
Compare
guys, I don't have bandwidth to fully explore this space right now, but please make sure that you align it with NodeJS and that we have some consistent plan for the relative paths of configured resources. We have open discussion on the PR I mentioned above and also we have @radical 's host and maybe some new shape of the config. All that said, I think we should just add |
Crypto worker is gone now.
So, I guess this PR is obsolete ? @jeromelaban |
@pavelsavara I guess it is! Thanks for the update. |
This change allows for resources like the crypto worker or thread workers to be resolved properly when used in a generic context.