[wasm] [debugger] Removing usage of serilog #70382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding serilog dlls
ghost
assigned 
|
@akoeplinger why we have to describe each dll? Can't we include all of them? |
|
/backport to release/7.0-preview5 |
|
Started backporting to release/7.0-preview5: https://github.com/dotnet/runtime/actions/runs/2456729433 |
thaystg
changed the title
|
/backport to release/7.0-preview5 |
|
Started backporting to release/7.0-preview5: https://github.com/dotnet/runtime/actions/runs/2457108327 |
thaystg
changed the title
akoeplinger
approved these changes
Jun 7, 2022
radical
approved these changes
Jun 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowserDebugHostis only used by blazorSerilogis used to log the chrome devtools protocol messages to a file. But this is used only if a log path is provided toBrowserDebugHost.So, we can drop the extraneous dependency.