Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON contract customization #70435

Merged
merged 10 commits into from
Jun 22, 2022
Merged

JSON contract customization #70435

merged 10 commits into from
Jun 22, 2022

Conversation

krwq
Copy link
Member

@krwq krwq commented Jun 8, 2022

Implements: #63686

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 8, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds contract customization.

This is WIP, it's easier to create comments and track remaining work this way

Author: krwq
Assignees: krwq
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone: -

@eiriktsarpalis
Copy link
Member

I think we need to add more tests for collection and dictionary metadata. Current set seems too focused on objects only.

@eiriktsarpalis
Copy link
Member

FWIW I ran the benchmark suite comparing the PR branch with the base commit and found no regressions. We should be good on that front.

krwq added 2 commits June 21, 2022 23:53
* PR feedback and extra tests

* Shorten class name, remove incorrect check (not true for polimorphic cases)
@krwq krwq marked this pull request as ready for review June 22, 2022 09:19
@krwq krwq mentioned this pull request Jun 22, 2022
16 tasks
krwq and others added 2 commits June 22, 2022 13:54
* Fix test failures and proper fix this time

* reinstate ActiveIssueAttribute

* PR feedback and adjust couple of tests which don't set TypeInfoResolver

* fix IAsyncEnumerable tests

* Lock JsonSerializerOptions in JsonTypeInfo.EnsureConfigured()

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants