Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parsing and working with CustomModifiers in field signatures and make TypeSystemMetadataEmitter more flexible #70593

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Add support for parsing and working with CustomModifiers in field signatures and make TypeSystemMetadataEmitter more flexible #70593

merged 2 commits into from
Jun 10, 2022

Commits on Jun 10, 2022

  1. Add support for parsing and working with CustomModifiers in field sig… 

    …natures and make TypeSystemMetadataEmitter more flexible

- Update TypeSystemMetadataEmitter to be able to generate a field signature given an appropriate array of EmbeddedSignatureData[]
- Add api to FieldDesc to allow the custom modifier data to be handled using the same scheme as custom modifier data on method signatures
- Adjust TypeSystemMetadataEmitter to be able to generate metadata not just for the Mibc emitter
  - The current implementation has some default behavior around creating metadata that is in the constructor. Break that out into helper functions so that other scenarios don't need to run that code.
  - Add an entrypoint for generating metadata for an arbitrary TypeSystemEntity
  - Add a feature to allow it the ResolutionScope of a non-nested type to be managed specially. This will be needed by dotnet#68919
    @davidwrighton
    davidwrighton committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    35f0638 View commit details
    Browse the repository at this point in the history

  2. Add empty space per review comment

    @davidwrighton
    davidwrighton committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    e47e44c View commit details
    Browse the repository at this point in the history