Revert "Add support for cross module inlining and cross module generi…c compilation to Crossgen2 (#68919)" #71076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c compilation to Crossgen2 (dotnet#68919)" This reverts commit 18ec279.
janvorli
approved these changes
Jun 21, 2022
|
If this finishes PR testing before I figure out the root cause here, I'll be checking this in. |
|
I've figured out the root cause, which is a long-standing bug in the generic methods implementation. As the fix strikes me as potentially a bit risky, I'm going to continue with this revert, and then test the actual fix along with the revert in a new PR, with an outerloop run before checkin this time. |
davidwrighton
added a commit
to davidwrighton/runtime
that referenced
this pull request
Jun 21, 2022
…e generic compilation to Crossgen2 (dotnet#68919)" (dotnet#71076)" This reverts commit 89dc073.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71023