-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#71252 disable AtanPiTest for android x86 #71256
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/cc @tannergooding |
@@ -1453,7 +1453,7 @@ public static void AsinPiTest(double value, double expectedResult, double allowe | |||
AssertExtensions.Equal(+expectedResult, double.AsinPi(+value), allowedVariance); | |||
} | |||
|
|||
[Theory] | |||
[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotAndroid), nameof(PlatformDetection.IsNotX86Process))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is being disabled due to #71252? We typically use [ActiveIssue(...)] for that. If that's not feasible because it doesn't support the exact condition, you can at least add the issue link as a comment next to the attribute. Otherwise it's likely we'll miss this in the future and it'll remain permanently disabled.
As per the comment by @drewnoakes on #71252, this is very likely a bug in Mono. We have existing tests validating Likewise,
Therefore |
/azp run runtime-extra-platforms |
Pull request contains merge conflicts. |
Closing this as Atan2PiTest is already changed only for 64bit by this commit |
Disabling AtanPiTest on android x86 due to #71252