Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ldelem[a]/stelem/cpobj/ldobj/stobj <pointer type> import #71679

Merged
merged 14 commits into from
Jul 28, 2022
Merged

Fix ldelem[a]/stelem/cpobj/ldobj/stobj <pointer type> import #71679

merged 14 commits into from
Jul 28, 2022

Commits on Jul 7, 2022

  1. Add a test for the ldelema case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    8c66661 View commit details
    Browse the repository at this point in the history

  2. Fix the ldelema case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    473cfce View commit details
    Browse the repository at this point in the history

  3. Add a test for the ldelem case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f88818c View commit details
    Browse the repository at this point in the history

  4. Fix the ldelem case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c806655 View commit details
    Browse the repository at this point in the history

  5. Add a test for the stelem case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    088e81f View commit details
    Browse the repository at this point in the history

  6. Fix the stelem case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    5ea93e6 View commit details
    Browse the repository at this point in the history

  7. Delete dead code while we're here

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b5d27df View commit details
    Browse the repository at this point in the history

  8. Add a test for the cpobj case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    607798f View commit details
    Browse the repository at this point in the history

  9. Fix the cpobj case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    125dd5c View commit details
    Browse the repository at this point in the history

  10. Fix stobj for consistency 

    There was no actual problem with it because the "stelem.ref"
logic takes the type to store from the value to store, but
let's make the code obviously correct.
    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    08bcd9f View commit details
    Browse the repository at this point in the history

  11. Add a test for the ldobj case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b4d8950 View commit details
    Browse the repository at this point in the history

  12. Fix the ldobj case

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    689ac11 View commit details
    Browse the repository at this point in the history

  13. Tighten asserts 

    They were relaxed in dotnet#50749.
    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9b76351 View commit details
    Browse the repository at this point in the history

  14. Add a TODO-CQ

    @SingleAccretion
    SingleAccretion committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6062b23 View commit details
    Browse the repository at this point in the history