[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues #71875

radical · 2022-07-09T08:41:40Z

Disabling FunctionalTests/System.Text.RegularExpressions.Tests because of a linker crash
Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.
Issue: [wasm] Linker crashing with System.NotImplementedException: switch #71848
Disabling some tests for System.Text.Json Serialization due to [wasm] STJ.Serialization.Tests failing with System.NotSupportedException with AOT #71838

- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this test for HighResourceAOT - Also, ensure that the HighResourceAOT tests are run for regular library tests, and EAT. Issue: dotnet#71848

ghost · 2022-07-09T08:41:50Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
test for HighResourceAOT
Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.

Issue: #71848

Author:	radical
Assignees:	-
Labels:	`arch-wasm`
Milestone:	-

radical · 2022-07-09T08:42:04Z

/azp run runtime-wasm

ghost · 2022-07-09T08:42:06Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Disabling FunctionalTests/System.Text.RegularExpressions.Tests this
test for HighResourceAOT
Also, ensure that the HighResourceAOT tests are run for regular
library tests, and EAT.

Issue: #71848

Author:	radical
Assignees:	radical
Labels:	`arch-wasm`, `area-Infrastructure-libraries`
Milestone:	-

azure-pipelines · 2022-07-09T08:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-07-09T09:58:54Z

/azp run runtime-wasm

azure-pipelines · 2022-07-09T09:59:04Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-07-09T19:45:17Z

/azp run runtime-wasm

azure-pipelines · 2022-07-09T19:45:30Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-07-10T05:26:51Z

/azp run runtime-wasm

azure-pipelines · 2022-07-10T05:27:00Z

Azure Pipelines successfully started running 1 pipeline(s).

This seems to be hit only with `EnableAggressiveTrimming=true`, and `RunAOTCompilation=true`. All the traces are similar to: ``` [FAIL] System.Text.Json.Serialization.Tests.CollectionTestsDynamic_AsyncStreamWithSmallBuffer.InvalidPropertyNameFail(policyType: typeof(System.Text.Json.Serialization.Tests.CollectionTests+KeyNameNullPolicy), offendingProperty: "Key") Assert.Throws() Failure Expected: typeof(System.InvalidOperationException) Actual: typeof(System.NotSupportedException): Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. ---- System.NotSupportedException : Metadata for type 'System.Collections.Generic.KeyValuePair`2[System.String,System.String]' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically. at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext() at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) ----- Inner Stack Trace ----- at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.StreamingJsonSerializerWrapper.<SerializeWrapper>d__11`1[[System.Collections.Generic.KeyValuePair`2[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]], System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].MoveNext() at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) at System.Text.Json.Serialization.Tests.CollectionTests.<>c__DisplayClass377_0.<<InvalidPropertyNameFail>b__0>d.MoveNext() --- End of stack trace from previous location --- at System.Text.Json.JsonSerializer.SerializeAsync[KeyValuePair`2](Stream , KeyValuePair`2 , JsonSerializerOptions , CancellationToken ) at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.AsyncStreamSerializerWrapper.SerializeWrapper[KeyValuePair`2](Stream utf8Json, KeyValuePair`2 value, JsonSerializerOptions options) ``` Issue: dotnet#71838

radical · 2022-07-11T20:51:18Z

/azp run runtime-wasm

azure-pipelines · 2022-07-11T20:51:27Z

Azure Pipelines successfully started running 1 pipeline(s).

lewing · 2022-07-11T22:32:10Z

cc @agocke

….JsonNameConflictOnCaseInsensitiveFail also

radical · 2022-07-11T23:03:02Z

Many jobs failing due to #71981 .

I need to disable one more test for the wasm/aot case, which I will push once the current wasm ones are done.

radical · 2022-07-11T23:58:00Z

/azp run runtime-wasm

azure-pipelines · 2022-07-11T23:58:13Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-07-12T02:42:38Z

Some of the failures are fixed by #71976 .

And we seem to have new tests failing with the same linker error now:

[01:14:27] fail: [FAIL] System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(type: typeof(System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute))
[01:14:27] info: Assert.Throws() Failure
[01:14:27] info: Expected: typeof(System.InvalidOperationException)
[01:14:27] info: Actual:   typeof(System.NotSupportedException): Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info: ---- System.NotSupportedException : Metadata for type 'System.Text.Json.Serialization.Tests.PropertyVisibilityTests+ClassWithBadIgnoreAttribute' was not provided to the serializer. The serializer method used does not support reflection-based creation of serialization-related type metadata. If using source generation, ensure that all root types passed to the serializer have been indicated with 'JsonSerializableAttribute', along with any types that might be serialized polymorphically.
[01:14:27] info:    at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info:    at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info:    at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info: ----- Inner Stack Trace -----
[01:14:27] info:    at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)
[01:14:27] info:    at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.<>c__DisplayClass172_0.<<JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson>b__1>d.MoveNext()
[01:14:27] info: --- End of stack trace from previous location ---
[01:14:27] info:    at System.Text.Json.Serialization.Tests.JsonSerializerWrapper.StringSerializerWrapper.SerializeWrapper[Object](Object value, JsonSerializerOptions options)

radical · 2022-07-12T02:51:46Z

/azp run runtime-wasm

azure-pipelines · 2022-07-12T02:51:59Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-07-12T06:43:33Z

The coreclr failure is #71995 .
The wasm/debugger failure is intermittent.

eiriktsarpalis · 2022-07-12T18:10:01Z

src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs

@@ -1178,7 +1191,7 @@ public async Task JsonIgnoreAttribute_UnsupportedCollection()

            var dictionary = new Dictionary<object, object>();
            // Uri is an unsupported dictionary key.
-            dictionary.Add(new Uri("http://foo"), "bar");
+            dictionary.Add(new Uri("http://typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]"), "bar");


This looks like an accidental change, could you revert please? cc @krwq

I'm actually surprised that this doesn't break other platforms.

[wasm] Disable tests failing on HighResourceAOT job

63b5ccb

- Disabling `FunctionalTests/System.Text.RegularExpressions.Tests` this test for HighResourceAOT - Also, ensure that the HighResourceAOT tests are run for regular library tests, and EAT. Issue: dotnet#71848

radical added the arch-wasm WebAssembly architecture label Jul 9, 2022

ghost assigned radical Jul 9, 2022

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Jul 9, 2022

Disable for EAT also

54c3c71

Merge branch 'dotnet:main' into disable-tests-highaot

ca44e51

radical changed the title ~~[wasm] Disable tests failing on HighResourceAOT job~~ [wasm] Disable tests failing due to linker crash Jul 9, 2022

radical changed the title ~~[wasm] Disable tests failing due to linker crash~~ [wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash Jul 9, 2022

radical changed the title ~~[wasm] Disable ST.RegularExpressions FunctionalTests tests failing due to linker crash~~ [wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash Jul 9, 2022

stephentoub approved these changes Jul 10, 2022

View reviewed changes

Merge branch 'dotnet:main' into disable-tests-highaot

0f567ee

radical added 2 commits July 11, 2022 19:25

Merge remote-tracking branch 'origin/main' into disable-tests-highaot

5d5d572

radical changed the title ~~[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker crash~~ [wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues Jul 11, 2022

radical requested review from lewing and akoeplinger July 11, 2022 22:03

Disable System.Text.Json.Serialization.Tests.PropertyNameTestsDynamic…

7be15f8

….JsonNameConflictOnCaseInsensitiveFail also

Disable another STJ failing test - dotnet#71981

e089914

radical mentioned this pull request Jul 12, 2022

[wasm] Fix some failing System.Runtime.InteropServices.JavaScript.Tests #71976

Merged

radical added 2 commits July 11, 2022 22:48

Merge remote-tracking branch 'origin/main' into disable-tests-highaot

4ff1162

[wasm] Disable two more tests failing due to dotnet#71838

31f9887

runfoapp bot mentioned this pull request Jul 12, 2022

System.Runtime.InteropServices.JavaScript.Tests.JSImportExportTest.JSImportObject #71990

Closed

radical mentioned this pull request Jul 12, 2022

System.Net.Quic.Functional.Tests crash on coreclr/windows/x64 #71995

Closed

radical merged commit cf83273 into dotnet:main Jul 12, 2022

radical deleted the disable-tests-highaot branch July 12, 2022 06:44

eiriktsarpalis reviewed Jul 12, 2022

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Aug 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues #71875

[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues #71875

radical commented Jul 9, 2022 •

edited

Loading

ghost commented Jul 9, 2022

radical commented Jul 9, 2022

ghost commented Jul 9, 2022

azure-pipelines bot commented Jul 9, 2022

radical commented Jul 9, 2022

azure-pipelines bot commented Jul 9, 2022

radical commented Jul 9, 2022

azure-pipelines bot commented Jul 9, 2022

radical commented Jul 10, 2022

azure-pipelines bot commented Jul 10, 2022

radical commented Jul 11, 2022

azure-pipelines bot commented Jul 11, 2022

lewing commented Jul 11, 2022

radical commented Jul 11, 2022

radical commented Jul 11, 2022

azure-pipelines bot commented Jul 11, 2022

radical commented Jul 12, 2022

radical commented Jul 12, 2022

azure-pipelines bot commented Jul 12, 2022

radical commented Jul 12, 2022

eiriktsarpalis Jul 12, 2022

eiriktsarpalis Jul 12, 2022

[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues #71875

[wasm] Disable S.T.RegularExpressions FunctionalTests tests failing due to linker issues #71875

Conversation

radical commented Jul 9, 2022 • edited Loading

ghost commented Jul 9, 2022

radical commented Jul 9, 2022

ghost commented Jul 9, 2022

azure-pipelines bot commented Jul 9, 2022

radical commented Jul 9, 2022

azure-pipelines bot commented Jul 9, 2022

radical commented Jul 9, 2022

azure-pipelines bot commented Jul 9, 2022

radical commented Jul 10, 2022

azure-pipelines bot commented Jul 10, 2022

radical commented Jul 11, 2022

azure-pipelines bot commented Jul 11, 2022

lewing commented Jul 11, 2022

radical commented Jul 11, 2022

radical commented Jul 11, 2022

azure-pipelines bot commented Jul 11, 2022

radical commented Jul 12, 2022

radical commented Jul 12, 2022

azure-pipelines bot commented Jul 12, 2022

radical commented Jul 12, 2022

eiriktsarpalis Jul 12, 2022

Choose a reason for hiding this comment

eiriktsarpalis Jul 12, 2022

Choose a reason for hiding this comment

[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues #71875

[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing due to linker issues #71875

radical commented Jul 9, 2022 •

edited

Loading