-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] reduce eval in production code #71932
Conversation
cc @kg |
- update benchmark to use JSExport/JSImport instead of reflection
Sorry guys, I realized that there is still usage in the benchmark. |
...ries/System.Runtime.InteropServices.JavaScript/System.Runtime.InteropServices.JavaScript.sln
Show resolved
Hide resolved
The time increase in this doesn't make any sense given the change in question, seems like variance? |
cae954a...4a2ebf2 is the only commit in the diff and it changes the test mechanism. it was known and mostly fixed with the lazy init I think |
Yes, I had to rewrite the benchmark to stop using eval code path and so I introduced dependency on JSExport into benchmark. The implementation at the time was triggering static constructors of the containing class during runtime init. That's now fixed in #77293 |
Fixes #61287