Override ReadAsync and WriteAsync methods on ConsoleStream. #71971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base Stream class implements these overloads by renting a buffer, creating a ReadWriteTask, and copying data as necessary. Instead, ConsoleStreams can just override these Async methods and synchronously call the underlying OS API. Add tests to verify that input and output console streams behave correctly.
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsThe base Stream class implements these overloads by renting a buffer, Instead, ConsoleStreams can just override these Async methods and synchronously Benchmarkpublic class ConsoleStreamsBenchmark
{
static byte[] _bytes = Encoding.ASCII.GetBytes("Hello, World!");
static Stream _stream = Console.OpenStandardOutput();
static NativeMemoryManager _nativeMemoryManager = CreateNativeMemory();
private unsafe static NativeMemoryManager CreateNativeMemory()
{
byte* mem = (byte*)NativeMemory.Alloc((nuint)_bytes.Length);
_bytes.AsSpan().CopyTo(new Span<byte>(mem, _bytes.Length));
return new NativeMemoryManager(mem, _bytes.Length);
}
[Benchmark]
public async Task WriteToStream()
{
await _stream.WriteAsync(_bytes);
}
[Benchmark]
public async Task WriteNativeMemoryToStream()
{
await _stream.WriteAsync(_nativeMemoryManager.Memory);
}
unsafe class NativeMemoryManager : MemoryManager<byte>
{
private byte* _pointer;
private int _length;
internal NativeMemoryManager(byte* pointer, int length)
{
_pointer = pointer;
_length = length;
}
public override Span<byte> GetSpan() => new Span<byte>(_pointer, _length);
public override MemoryHandle Pin(int elementIndex = 0) => default;
public override void Unpin() { }
protected override void Dispose(bool disposing) { }
}
}Results
|
stephentoub
reviewed
Jul 11, 2022
stephentoub
reviewed
Jul 11, 2022
stephentoub
reviewed
Jul 11, 2022
stephentoub
reviewed
Jul 11, 2022
|
The new "OpenStandardInput" tests need to be skipped on platforms that don't support standard input - like wasm, ios, and android. Fixing... |
adamsitnik
approved these changes
Jul 12, 2022
|
/azp list |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
All the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base Stream class implements these overloads by renting a buffer,
creating a ReadWriteTask, and copying data as necessary.
Instead, ConsoleStreams can just override these Async methods and synchronously
call the underlying OS API.
Benchmark
Results