Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAR tests that verify ExtractToFile works with special files #71988

Merged

Conversation

carlossanlop
Copy link
Member

We already have tests that verify:

  • The creation of TarEntry instances for fifo, block & character device entry types.
  • Reading them from an archive, verifying the correct values of DeviceMajor and DeviceMinor.
  • Reading them from the filesystem and generating TarEntry instances, verifying the correct values of DeviceMajor and DeviceMinor.
  • Writing them to an archive, and verifying the data was correctly written.
  • Checking that an exception is thrown when the user is not a superuser in Unix when attempting to extract such entries.
  • Checking they are unsupported entries on Windows.

But we don't yet have tests for successful extraction of such entries entry types to the file system.

Pending confirm that the exotic runtime-extra-platforms do not have weird behaviors.

@carlossanlop carlossanlop added this to the 7.0.0 milestone Jul 12, 2022
@carlossanlop carlossanlop self-assigned this Jul 12, 2022
@ghost
Copy link

ghost commented Jul 12, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

We already have tests that verify:

  • The creation of TarEntry instances for fifo, block & character device entry types.
  • Reading them from an archive, verifying the correct values of DeviceMajor and DeviceMinor.
  • Reading them from the filesystem and generating TarEntry instances, verifying the correct values of DeviceMajor and DeviceMinor.
  • Writing them to an archive, and verifying the data was correctly written.
  • Checking that an exception is thrown when the user is not a superuser in Unix when attempting to extract such entries.
  • Checking they are unsupported entries on Windows.

But we don't yet have tests for successful extraction of such entries entry types to the file system.

Pending confirm that the exotic runtime-extra-platforms do not have weird behaviors.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.IO

Milestone: 7.0.0

@carlossanlop
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @carlossanlop !

@carlossanlop
Copy link
Member Author

The test failures in runtime-extra-platforms are unrelated to Tar.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants