-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TAR tests that verify ExtractToFile works with special files #71988
Add TAR tests that verify ExtractToFile works with special files #71988
Conversation
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsWe already have tests that verify:
But we don't yet have tests for successful extraction of such entries entry types to the file system. Pending confirm that the exotic runtime-extra-platforms do not have weird behaviors.
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @carlossanlop !
The test failures in runtime-extra-platforms are unrelated to Tar. |
We already have tests that verify:
TarEntry
instances for fifo, block & character device entry types.DeviceMajor
andDeviceMinor
.TarEntry
instances, verifying the correct values ofDeviceMajor
andDeviceMinor
.But we don't yet have tests for successful extraction of such entries entry types to the file system.
Pending confirm that the exotic runtime-extra-platforms do not have weird behaviors.