Make llvm-objcopy preferred; no required #72208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
am11
force-pushed
the
feature/nativeaot/symbol-stripping
branch
3 times, most recently
from
3bebef1 to
1e8389e
Compare
am11
force-pushed
the
feature/nativeaot/symbol-stripping
branch
from
1e8389e to
0dd5d02
Compare
MichalStrehovsky
added a commit
to dotnet/sdk
that referenced
this pull request
Jul 19, 2022
This should not be needed after dotnet/runtime#72208. Let's test the mainstream scenario. Also flipping the if check to prepare for macOS testing at some point.
MichalStrehovsky
added a commit
to dotnet/sdk
that referenced
this pull request
Jul 20, 2022
This should not be needed after dotnet/runtime#72208. Let's test the mainstream scenario. Also flipping the if check to prepare for macOS testing at some point.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #72155
The
llvmpackage on Debian distros installsllvm-objcopy, but the NativeAOT prerequisite doc does not requirellvmpackage (in addition toclang): https://docs.microsoft.com/en-us/dotnet/core/deploying/native-aot#prerequisitesThis PR makes
llvm-objcoypreferred but not required when clang is used. It will gracefully fallback to binutilsobjcopy, which gets installed withclangpackage (at least on Debian distros).