Add X509 SAN extension and RFC6125 MatchesHostname #72304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsFixes #22699.
|
vcsjones
reviewed
Jul 16, 2022
....Security.Cryptography.X509Certificates/tests/ExtensionsTests/SubjectAlternativeNameTests.cs
Show resolved
Hide resolved
....Security.Cryptography.X509Certificates/tests/ExtensionsTests/SubjectAlternativeNameTests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.X509Certificates/tests/MatchesHostnameTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.X509Certificates/tests/MatchesHostnameTests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
Outdated
Show resolved
Hide resolved
....Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Show resolved
Hide resolved
....Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Show resolved
Hide resolved
....Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Show resolved
Hide resolved
|
Should this PR be |
I went ahead and marked it as such, since the EKU check can be done by X509Chain. There's probably still room for ease of use there, but I'll let it come back as a separate proposal. |
vcsjones
reviewed
Jul 19, 2022
....Security.Cryptography.X509Certificates/tests/ExtensionsTests/SubjectAlternativeNameTests.cs
Show resolved
Hide resolved
vcsjones
reviewed
Jul 19, 2022
src/libraries/System.Security.Cryptography.X509Certificates/tests/MatchesHostnameTests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.X509Certificates/tests/MatchesHostnameTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.X509Certificates/tests/MatchesHostnameTests.cs
Show resolved
Hide resolved
....Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Outdated
Show resolved
Hide resolved
....Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Outdated
Show resolved
Hide resolved
* Clarify the position on SRV-ID and URI-ID matching in API docs and tests * Add some more IPv6 tests * Delete a now-redundant test * Change a dead if to an assert.
vcsjones
approved these changes
Jul 20, 2022
stephentoub
approved these changes
Jul 20, 2022
ghost
locked as resolved and limited conversation to collaborators
bartonjs
added
the
needs-further-triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22699.
Fixes #59870.